Widgets that depend on Material should assert that #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
force-pushed
the
check_material
branch
2 times, most recently
from
8c85ac8 to
d15f220
Compare
After this patch, if you try to use a widget that depends on being enclosed in a material, you now get an assert and a debugPrint if you're not inside a material. Fixes flutter#243
abarth
force-pushed
the
check_material
branch
from
d15f220 to
8dc607a
Compare
Contributor
|
LGTM. I didn't check if there were widgets that should get this that you didn't put it in. |
abarth
added a commit
that referenced
this pull request
Dec 8, 2015
Widgets that depend on Material should assert that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this patch, if you try to use a widget that depends on being enclosed in
a material, you now get an assert and a debugPrint if you're not inside a
material.
Fixes #243