-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Migrate build to null safety #81106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build to null safety #81106
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Do we need this test when we are migrating this to null safety @jmagman ? |
|
We will migrate this when |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Abhishek01039 all imported libraries need to be migrated before this can be migrated. This is stuck behind |
|
I am also waiting for |
|
Hello @jonahwilliams |
|
@Abhishek01039 artifacts has been migrated to null safety, you can rebase on top of tree. |
|
Also please migrate build_test at the same time. |
|
Lots of failing tests |
|
CI getting an error in |
|
CI is green right now so if the test is failing is because of your changes unfortunately |
Filed #83275. Run |
|
This was blocking the next clump of migrations, I have a version in #83381. |

Part of #71511