Add skp_generator shard to LUCI config #81096
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM (pending the pre-submit passes ofc)
|
@christopherfujino clearly i did something wrong, the test isn't completing and i can't see logs... |
|
The builder definitely exists: https://ci.chromium.org/p/flutter/builders/try/Linux%20skp_generator. I wonder if maybe you opened this PR before new builder had propagated to LUCI, or if cocoon (which does pre-submit scheduling) had some caching? Re-triggering the build, and I'll come back to check on Monday. |
|
Oh annoying, I guess if it's "pending" you can't re-run. |
|
I repushed, that should do it. |
It ran and passed. This PR looks good to go. I looked at the timestamps, and this PR was opened 7 minutes before your infra change was merged. I'll add a special note on the wiki page that opening this framework PR before the infra change has propagated will lead to bad times. |
|
Awesome, thanks! |
|
Checked the logs for the test and it ran as expected. Landing. |
|
This was further tweaked it #82239. |
2 participants
Fixes #80906
Depends on https://github.com/flutter/infra/pull/422
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.