[flutter_tools] pin transitive deps during --transitive-closure #80911
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
| result.writeln('name: flutter_update_packages'); | ||
| result.writeln('environment:'); | ||
| result.writeln(" sdk: '>=2.10.0 <3.0.0'"); | ||
| result.writeln(" sdk: '>=2.12.0 <3.0.0'"); |
There was a problem hiding this comment.
while I'm at it...
|
test-exempt: clearly this is already tested since the tests failed ;-) |
|
Actually, I did this wrong - but the tests are still failing thankfully :D |
|
Actually rewrote the logic a bit so for --transitive-closure we only look at the deps of the current packages instead of the generated package. |
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
LGTM still, with the changes.
3 participants
This fixes the existing analysis test. Fixes #80909
When printing the transitive closure, ensure that all dependencies - even transitive dependencies - are pinned in the synthetic pubspec. This prevents us from accidentally grabbing new versions of transitive deps without a roll into the flutter tool.
This was only a problem with --transitive-closure, for update-packages --force-upgrade it is expected that we leave transitive deps unpinned to reduce the constraints for a new version solve