Skip to content

Migrate pub in flutter_tools to null safety #80548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Apr 17, 2021
Merged

Migrate pub in flutter_tools to null safety #80548

jmagman merged 1 commit into from
Apr 17, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 16, 2021

Part of #71511

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for Dart's null safety feature labels Apr 16, 2021
@jmagman jmagman self-assigned this Apr 16, 2021
@google-cla google-cla bot added the cla: yes label Apr 16, 2021
jmagman
jmagman commented Apr 16, 2021
View reviewed changes
packages/flutter_tools/test/general.shard/build_system/source_test.dart

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fake_process_manager.dart';
Copy link
Member Author

@jmagman jmagman Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but noticed this file was just using the exported fake_process_manager, which is null safe.

@jmagman jmagman requested a review from jonahwilliams April 16, 2021 20:22
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Apr 16, 2021

Trade you for #80462

@jmagman
Copy link
Member Author

jmagman commented Apr 16, 2021

Trade you for #80462

Done.

jonahwilliams
jonahwilliams approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 8d5f08f into flutter:master Apr 17, 2021
@jmagman jmagman deleted the null-pub branch April 17, 2021 00:23
@swift-kim swift-kim mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @jonahwilliams