Skip to content

Revert "Support block delete with word and line modifiers" - #79968

Merged
jmagman merged 1 commit into
masterfrom
revert-79695-fix-block-delete-v2
Apr 7, 2021
Merged

Revert "Support block delete with word and line modifiers"#79968
jmagman merged 1 commit into
masterfrom
revert-79695-fix-block-delete-v2

Conversation

@jmagman

@jmagman jmagman commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Reverts #79695

This caused test failures:

03:16 +5088 ~14 -1: /b/s/w/ir/k/flutter/packages/flutter/test/rendering/editable_test.dart: RenderEditable registers and unregisters raw keyboard listener correctly [E]
  Expected: 'ow are you'
    Actual: 'how are you'
     Which: is different.
            Expected: ow are you ...
              Actual: how are yo ...
                      ^
             Differ at offset 0

  package:test_api                                   expect
  package:flutter_test/src/widget_tester.dart 440:3  expect
  test/rendering/editable_test.dart 1209:5           main.<fn>

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8850588200510579840/+/steps/run_test.dart_for_framework_tests_shard_and_subshard_libraries/0/logs/stdout/0

\cc @canastro

@jmagman
jmagman requested a review from justinmc April 7, 2021 18:44
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 7, 2021
@google-cla google-cla Bot added the cla: yes label Apr 7, 2021
@jmagman

jmagman commented Apr 7, 2021

Copy link
Copy Markdown
Member Author

Merging to green the tree.

@jmagman
jmagman merged commit a637fcd into master Apr 7, 2021
@jmagman
jmagman deleted the revert-79695-fix-block-delete-v2 branch April 7, 2021 18:44
@jmagman

jmagman commented Apr 7, 2021

Copy link
Copy Markdown
Member Author

@justinmc might be worth investigating why framework_tests_libraries passed in presubmit but failed in post https://ci.chromium.org/p/flutter/builders/try/Linux%20framework_tests_libraries/847?

@christopherfujino

christopherfujino commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

LGTM

@canastro

canastro commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

It happened the same thing it did the first time this fix was merged. A test was added in master in between the last rebase and the time it got merged. I'll investigate the failing test and open the PR with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @canastro