Form needs to clean up its scopedWillPopCallback #7936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Feb 7, 2017
Contributor
There was a problem hiding this comment.
this needs to unhook if _route is non-null before calling ModalRoute.of
Contributor
Author
There was a problem hiding this comment.
Good point. In this case _route might be null before or after the ModalRoute.of(context) line. Similarly, _route could be null at dispose time.
void dependenciesChanged() {
super.dependenciesChanged();
_route?.removeScopedWillPopCallback(askTheUserIfTheyAreSure);
_route = ModalRoute.of(context);
_route?.addScopedWillPopCallback(askTheUserIfTheyAreSure);
}
Contributor
|
|
HansMuller
force-pushed
the
will_pop_callback_disposal
branch
from
07d2e6a to
4dbe936
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation to remind developers to do the same.
Fixes #7896
Fixes #7895