-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add split Linux docs jobs to prod builder json #78888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "task_name": "linux_docs_test", | ||
| "flaky": true | ||
| }, | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Linux docs_publish run only in release branches? adding it here will run it for master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's supposed to run on master, just not the release candidate branches:
https://github.com/flutter/infra/blob/e83d25832f6b56a7651365076eb842f57328343a/config/packaging_config.star#L149-L152
# Docs builds are only done on master and stable channels
if branch in ("master", "stable"):
common.linux_prod_builder(
name = "Linux%s docs_publish|docs" % ("" if branch == "master" else " " + branch),
I'll wait until @christopherfujino comes back from vacation, he can validate that's what he intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is correct, provided we follow-up to mark un-flaky.
confusingly, docs are published only on master (https://master-api.flutter.dev) and stable channels (https://api.flutter.dev).
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
Linux docsprod builder was split intoLinux docs_testandLinux docs_publishin https://github.com/flutter/infra/pull/375. Add them to the framework builders json file.Linux docswas showing up as not running:Note the try job is still called
Linux docs.Fixes #78887