Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 23, 2021

The Linux docs prod builder was split into Linux docs_test and Linux docs_publish in https://github.com/flutter/infra/pull/375. Add them to the framework builders json file.

Linux docs was showing up as not running:
Screen Shot 2021-03-23 at 11 19 00 AM

Note the try job is still called Linux docs.

Fixes #78887

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 23, 2021
@jmagman jmagman self-assigned this Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@jmagman jmagman changed the title Add split Linux docs jobs to builders Add split Linux docs jobs to prod builder json Mar 23, 2021
@jmagman jmagman requested a review from godofredoc March 23, 2021 19:50
"task_name": "linux_docs_test",
"flaky": true
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Linux docs_publish run only in release branches? adding it here will run it for master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's supposed to run on master, just not the release candidate branches:
https://github.com/flutter/infra/blob/e83d25832f6b56a7651365076eb842f57328343a/config/packaging_config.star#L149-L152

    # Docs builds are only done on master and stable channels
    if branch in ("master", "stable"):
        common.linux_prod_builder(
            name = "Linux%s docs_publish|docs" % ("" if branch == "master" else " " + branch),

I'll wait until @christopherfujino comes back from vacation, he can validate that's what he intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is correct, provided we follow-up to mark un-flaky.

confusingly, docs are published only on master (https://master-api.flutter.dev) and stable channels (https://api.flutter.dev).

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit f12d90c into flutter:master Mar 29, 2021
@jmagman jmagman deleted the docs-test branch March 29, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linux_docs has not run on prod in recent runs

3 participants