Skip to content

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Mar 23, 2021

Reverts #77414 This PR breaks Google internal tests.

@renyou renyou requested a review from justinmc March 23, 2021 13:21
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 23, 2021
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is a failure here in web_integration_tests, but it seems to be unrelated.

Though, it doesn't seem to me like this PR should have caused these failures. I'm investigating.

@renyou
Copy link
Contributor Author

renyou commented Mar 23, 2021

Merge on red because this is a clean revert of a relative new PR not too far from ToT.

@renyou renyou merged commit b921a24 into master Mar 23, 2021
@renyou renyou deleted the revert-77414-iv-builder branch March 23, 2021 15:11
@CaseyHillers
Copy link
Contributor

Thanks @renyou for unblocking the tree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants