Make kPestoRecipes a constant #7886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone on stack overflow was mutating the list of recipes and getting confused about why the UI didn't redraw. Making kPestoRecipes a constant might help avoid that confusion.
Contributor
Author
Contributor
|
|
Hixie
pushed a commit
to Hixie/flutter
that referenced
this pull request
Feb 4, 2017
Someone on stack overflow was mutating the list of recipes and getting confused about why the UI didn't redraw. Making kPestoRecipes a constant might help avoid that confusion.
Contributor
|
Cc @mit for feedback on workflow. This comes up with new users.
…On Sat, Feb 4, 2017, 9:33 AM Adam Barth ***@***.***> wrote:
Merged #7886 <#7886>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7886 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAVZ0TTu0hdyAmQ9jDrvDVL4ypZ6e-iks5rZLaFgaJpZM4L3M5I>
.
|
Contributor
|
Should this kind of code pattern go into Effective Flutter (when we write Effective Flutter, that is :) I want to collect patterns for our upcoming doc: #7044 |
Contributor
Author
|
Using const data like this is useful for demos, but I suspect real apps will want to get there data from some live source, like disk or network. |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Feb 21, 2019
flutter/engine@293b3de98 Roll src/third_party/skia 20ebd0cb3882..348227b89430 (4 commits) (flutter/engine#7900) flutter/engine@6e6020d29 Eliminate .member = foo struct initialization (flutter/engine#7899) flutter/engine@6d8bd99af Revert "Reland PerformanceOverlayLayer golden test (flutter/engine#7863)" (flutter#7895) flutter/engine@39f7066b6 Test profile and release build and unit tests (flutter/engine#7880) flutter/engine@abe9826a9 Add accessibility semantics support to embedder (flutter/engine#7891) flutter/engine@ce7016e1f Roll src/third_party/skia e471c05f92e8..20ebd0cb3882 (4 commits) (flutter/engine#7894) flutter/engine@684c9394c Respect the custom GL proc table when creating the resource context on the IO thread. (flutter/engine#7893) flutter/engine@e11d0e96f Android embedding refactor pr5 add flutterengine impl (flutter/engine#7878) flutter/engine@2f4a38dbd Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7892) flutter/engine@8427d73c8 Reland PerformanceOverlayLayer golden test (flutter/engine#7863) flutter/engine@61fc1786f Roll src/third_party/dart c92d5ca288..5ddd157809 (153 commits) flutter/engine@b0671145a Roll src/third_party/skia 7738736f9622..e471c05f92e8 (23 commits) (flutter/engine#7889) flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter#7886)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone on stack overflow was mutating the list of recipes and getting
confused about why the UI didn't redraw. Making kPestoRecipes a constant
might help avoid that confusion.