Skip to content

[State Restoration] Code sample templates, migrate existing code samples #78757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shihaohong merged 10 commits into from
Mar 23, 2021
Merged

[State Restoration] Code sample templates, migrate existing code samples #78757

shihaohong merged 10 commits into from
Mar 23, 2021

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Mar 22, 2021 •
edited
Loading

Fixes #78756.

  • Adds stateful and stateless widget API sample templates for state restoration.
  • Migrates existing state restoration samples to make use of the new template.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 22, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@shihaohong shihaohong added a: state restoration RestorationManager and related APIs d: api docs Issues with https://api.flutter.dev/ labels Mar 22, 2021
@shihaohong shihaohong mentioned this pull request Mar 22, 2021
Merged
8 tasks
@shihaohong shihaohong requested a review from goderbauer March 22, 2021 05:10
@shihaohong shihaohong changed the title [WIP] [State Restoration] Code sample templates, migrate existing code samples [State Restoration] Code sample templates, migrate existing code samples Mar 22, 2021
goderbauer
goderbauer approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Mar 23, 2021
Merged
8 tasks
@shihaohong
Copy link
Contributor Author

shihaohong commented Mar 23, 2021

Merging as only Cirrus tests are failing due to known issue (#78758), but all the equivalent LUCI tests are passing

@shihaohong shihaohong merged commit 49adef6 into flutter:master Mar 23, 2021
@shihaohong shihaohong deleted the state-restoration-sample-template branch March 23, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: state restoration RestorationManager and related APIs c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[State Restoration] Create a state restoration template to reduce the boilerplate of sample code

2 participants

@shihaohong @goderbauer