Skip to content

Typo fixes #78755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shihaohong merged 1 commit into from
Mar 23, 2021
Merged

Typo fixes #78755

shihaohong merged 1 commit into from
Mar 23, 2021

Conversation

@shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Mar 22, 2021

Fix to typos in the documentation. Also removes an extra newline in the code.

@shihaohong shihaohong requested a review from xu-baolin March 22, 2021 03:06
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@shihaohong shihaohong mentioned this pull request Mar 22, 2021
Merged
8 tasks
xu-baolin
xu-baolin approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@xu-baolin xu-baolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong mentioned this pull request Mar 22, 2021
Closed
@shihaohong
Copy link
Contributor Author

shihaohong commented Mar 23, 2021

Merging as only Cirrus tests are failing due to known issue (#78758), but all the equivalent LUCI tests are passing

@shihaohong shihaohong merged commit 7a88eb9 into flutter:master Mar 23, 2021
@shihaohong shihaohong deleted the misc-changes branch April 19, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xu-baolin xu-baolin xu-baolin approved these changes

+1 more reviewer

@eli-front eli-front eli-front approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shihaohong @xu-baolin @eli-front