Skip to content

Added cupertino scrollbar fling test #78689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kavantix wants to merge 2 commits into from
Closed

Added cupertino scrollbar fling test #78689

Kavantix wants to merge 2 commits into from

Conversation

@Kavantix
Copy link
Contributor

@Kavantix Kavantix commented Mar 20, 2021

This pr add a (currently failing) widget test to show that flinging the scrollbar on iOS is currently broken. (see issue #78688)
When you run this test on 1.22.6 it does succeed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 20, 2021
@google-cla google-cla bot added the cla: yes label Mar 20, 2021
@Kavantix Kavantix mentioned this pull request Mar 20, 2021
Closed
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 9, 2021

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks
Copy link
Contributor

Piinks commented Jun 10, 2021

Hey @Kavantix thank you for writing a test case! We will be sure to include this when #78688 is fixed. Since this cannot land in its current state, I am going to close this for now. Thank you!

@Piinks Piinks closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kavantix @Piinks