Skip to content

Refactor text editing test APIs #78637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hixie wants to merge 1 commit into from
Closed

Refactor text editing test APIs #78637

Hixie wants to merge 1 commit into from

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Mar 19, 2021 •
edited
Loading

...and remove a legacy TODO whose referenced issue (#51885) is now closed.

To actually fix this required some refactoring of the text editing test APIs.

See #77454 for original discussion.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 19, 2021
@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Mar 19, 2021

As it stands this is known to break some Google tests. I'll need to study this more to work out why or how.

@Hixie
Copy link
Contributor Author

Hixie commented Mar 25, 2021

Closing in favour of #79061.

@Hixie Hixie closed this Mar 25, 2021
@Hixie Hixie mentioned this pull request May 7, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 14, 2021
@Hixie
Migrate to ChannelBuffers.push
f536a68 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
@Hixie Hixie mentioned this pull request May 14, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 21, 2021
@Hixie
Migrate to ChannelBuffers.push
a87a5f5 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hixie