Skip to content

Conversation

@angjieli
Copy link
Contributor

@angjieli angjieli commented Mar 18, 2021

Reverts #77454

This has caused some internal failures.

@angjieli angjieli requested a review from Hixie March 18, 2021 23:08
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 18, 2021
@google-cla google-cla bot added the cla: yes label Mar 18, 2021
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"internal" meaning within google in this case.

@angjieli
Copy link
Contributor Author

Going to manually merge this since it is a revert.

@angjieli angjieli merged commit 6515806 into master Mar 19, 2021
@angjieli angjieli deleted the revert-77454-todo51885 branch March 19, 2021 17:08
angjieli added a commit to angjieli/flutter1 that referenced this pull request Mar 19, 2021
angjieli added a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants