Skip to content

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Mar 16, 2021

Added iconColor, collapsedIconColor, textColor and collapsedTextColor properties to ExpansionTile. If specified, they define the colors of the trailing expand/collapse icon and the colors of the tile's title and subtitle. Although the default values for these colors were never documented, some apps have created dependencies on the default values and were using Theme overrides to set them.

The new properties were added to so that apps could specify the colors directly, rather on depending the undocumented defaults - which included accentColor just for the trailing icon's color - per #56918.

Tested against internal apps: /cl/362300735

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 16, 2021
@google-cla google-cla bot added the cla: yes label Mar 16, 2021
@HansMuller HansMuller requested a review from darrenaustin March 16, 2021 02:21
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller force-pushed the add_expansion_tile_color_properties branch from 8d15512 to 9232517 Compare March 16, 2021 17:42
@HansMuller HansMuller merged commit 14b8194 into flutter:master Mar 16, 2021
@HansMuller HansMuller deleted the add_expansion_tile_color_properties branch March 16, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants