Removed accentColor dependency from ExpansionTile #77933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
19 tasks
darrenaustin
approved these changes
Mar 11, 2021
Contributor
There was a problem hiding this comment.
Neat trick with the fromSwatch(). I will have to remember that for my own tests in the future.
HansMuller
force-pushed
the
remove_accent_color_in_expansion_tile
branch
from
cc409f7 to
524a0a2
Compare
HansMuller
pushed a commit
that referenced
this pull request
Mar 25, 2021
This reverts commit 82f1d63.
fluttergithubbot
pushed a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon and title text color for expanded tiles is now the overall theme's ColorScheme.secondary color instead of the theme's accentColor. This PR removes the widget's accentColor dependency per #56918.
This is technically not a breaking change, because it doesn't break any existing tests.
Depends on internal Google changes: cl/365624789