Removed MaterialApp accentColor dependency. #77652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the MaterialApp widget's accentColor dependency per #56918.
The reference in question was used to set the
GlowingOverscrollIndicator's color that is created for Material viewports. This PR updates this to now use thecolorScheme.secondaryfor the overscroll indicator instead.Breaking change
This is a breaking change, although most apps will not notice the change from theme.accentColor to theme.colorScheme.secondary, because they are typically the same color. For apps that do need a
specific color for the glow indicator, you can wrap your scrollable with something like:
Which will force the glow color to yellow.
A new test was added to check verify the overscroll indicator color for Material apps.
This PR was tested against internal Google apps in cl/360771909