Fix a legacy TODO #77454
Merged
Fix a legacy TODO #77454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
Contributor
Author
|
cc @dnfield |
juchef
approved these changes
Mar 6, 2021
dnfield
approved these changes
Mar 6, 2021
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
lgtm assuming tests pass
Contributor
Author
|
@yjbanov Can you give me any advice here? |
Contributor
Author
|
Ok well I figured out why what we'd changed didn't fix it. Turns out, before each test, we call Also it turns out tests (including public documentation) depends on |
Hixie
force-pushed
the
todo51885
branch
3 times, most recently
from
a50adf4 to
f287323
Compare
The referenced issue is now closed.
flutter-dashboard
bot
added
a: tests
Contributor
Author
|
Ok I did some refactoring and cleaned this stuff up so now it passes. Hopefully this passes google3 too... |
Contributor
Author
|
cc @goderbauer for flutter_test changes |
Contributor
Author
|
cc @yjbanov since it affects web_e2e_tests |
angjieli
added a commit
that referenced
this pull request
Mar 19, 2021
angjieli
added a commit
to angjieli/flutter1
that referenced
this pull request
Mar 19, 2021
This reverts commit 5e4e530.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Mar 19, 2021
8 tasks
8 tasks
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Apr 3, 2021
fluttergithubbot
pushed a commit
that referenced
this pull request
Apr 3, 2021
justinmc
added a commit
that referenced
this pull request
Apr 7, 2021
8 tasks
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Apr 21, 2021
...and remove a legacy TODO whose referenced issue (flutter#51885) is now closed. To actually fix this required some refactoring of the text editing test APIs. See flutter#77454 and flutter#79061 for earlier discussions. This was last reverted in flutter#79559.
This was referenced May 2, 2021
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 14, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 21, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced issue (#51885) is now closed.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.