fix Autovalidate enum references in fix data #77419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
Piinks
approved these changes
Mar 5, 2021
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Oh wow! Thanks! I am not sure if the dart fixes can add an import, @bwilkerson is that possible?
Typo fix LGTM
Contributor
|
Yes, they can. The replacement text can use a variable and the variable can be specified as type 'import'. |
Piinks
reviewed
Mar 5, 2021
| expression: 'AutovalidateMode.disabled' | ||
| requiredIf: "autovalidate == 'false'" | ||
| - kind: 'removeParameter' | ||
| name: 'autovalidate' |
Contributor
There was a problem hiding this comment.
Below here, under variables you should be able to add the import if I understand it right
Like:
kind: import
uris: [ 'package:flutter/material.dart' ]
name: 'Widget'
I haven't found an example of this yet, but I am looking into it now. Thanks @bwilkerson!
Contributor
There was a problem hiding this comment.
I can add this in a follow-up change, it'll take a bit more refactoring I think. :)
Contributor
|
Hey @kf6gpe, I don't think this was cherrypicked to 2.0. Did we get something mixed up in the cp tracking? |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Mar 17, 2021
christopherfujino
added a commit
that referenced
this pull request
Mar 19, 2021
* Avoid iOS local networking dialog in integration tests (#75163) * ios_platform_view tests pass when device rotated (#75665) * Consolidate ascii spinner stop in devtools activation (#75679) * Fix problem causing tasks to timeout. (#76028) This is because the command was actually collecting logs continuously from the device. Additionally idevicesyslog does not have a reboot option. Bug: #76027 * fix Autovalidate enum references in fix data (#77419) * roll engine cherrypicks Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: godofredoc <[email protected]> Co-authored-by: Phil Quitslund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo in the fix data file which leads to generating bogus (non-existent) enum references.
It's also worth noting that these fixes don't auto add the required import. (There's a way to do that with variables but I don't quite know the magic...)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.