Skip to content

Apply changes caused by https://github.com/flutter/flutter/pull/76662 #77093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 3, 2021
Merged

Apply changes caused by https://github.com/flutter/flutter/pull/76662 #77093

fluttergithubbot merged 1 commit into from
Mar 3, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Mar 2, 2021 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 2, 2021
@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@Hixie Hixie mentioned this pull request Mar 2, 2021
Merged
@Hixie
Copy link
Contributor Author

Hixie commented Mar 2, 2021

This probably needs a test; I'm thinking maybe we should add something to the end of each shard that makes sure there's no local changes in the workspace? Not quite sure how to do that.
cc @jonahwilliams

@jmagman
Copy link
Member

jmagman commented Mar 2, 2021

Not sure if there are more, but if you run SHARD=build_tests dart dev/bots/test.dart locally it will build (and therefore update generated_plugin_registrant) all the example and integration tests.

#76726

@Hixie
Copy link
Contributor Author

Hixie commented Mar 2, 2021

I thought I had, but that was on another PR's branch so maybe when I stashed the changes I didn't apply things sufficiently.

@jmagman
Copy link
Member

jmagman commented Mar 2, 2021 •
edited
Loading

I thought I had, but that was on another PR's branch so maybe when I stashed the changes I didn't apply things sufficiently.

Ah okay those might be the only ones then.

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Mar 2, 2021

I'm not sure what the current state of the art for LUCI testing is. Since we generate the plugin registrants during a pub get, I think checking after running flutter pub get in each repo would be sufficient. Maybe we should update flutter update-packages so that it also does this?

@Hixie
Copy link
Contributor Author

Hixie commented Mar 2, 2021

This isn't the only source of local changes we've ever had. I was imagining that we'd literally just end every shard with a quick check to see if git diff had any output, because if it does then that's a problem in general.

I guess I can literally just do git diff --exit-code at the end of every shard...

@Hixie
Copy link
Contributor Author

Hixie commented Mar 2, 2021

Experimenting with #77100

blasten
blasten approved these changes Mar 2, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Mar 3, 2021

I'll land this on green, I have tests for it in #77100

@fluttergithubbot fluttergithubbot merged commit cdca648 into flutter:master Mar 3, 2021
zanderso added a commit that referenced this pull request Mar 19, 2021
@zanderso
Revert "Apply changes caused by #76662 (#77093)"
e54fb7e 
This reverts commit cdca648.
zanderso added a commit that referenced this pull request Mar 20, 2021
@zanderso
Revert "Apply changes caused by #76662 (#77093)"
dc8fa30 
This reverts commit cdca648.
zanderso added a commit that referenced this pull request Mar 23, 2021
@zanderso
Revert "Apply changes caused by #76662 (#77093)"
e95c99f 
This reverts commit cdca648.
zanderso added a commit that referenced this pull request Mar 23, 2021
@zanderso
Revert "Apply changes caused by #76662 (#77093)"
e37d92e 
This reverts commit cdca648.
zanderso added a commit that referenced this pull request Mar 23, 2021
@zanderso
Reverts "Implement dartPluginClass support for plugins #74469" (#78623)
5efc716 
* Revert "Enable dart_plugin_registry_test (#76645)"

This reverts commit 109e0bb.

* Revert "Apply changes caused by #76662 (#77093)"

This reverts commit cdca648.

* Revert "Disable clang format in the plugin registrants (#76662)"

This reverts commit dadbd47.

* Revert "Disable warnings for the dart plugin registrant (#76561)"

This reverts commit 098ece5.

* Revert "Remove dart_plugin_registry_test timeouts (#76838)"

This reverts commit 1610a27.

* Revert "Implement dartPluginClass support for plugins (#74469)"

This reverts commit b7d4806.

Kick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hixie @jmagman @jonahwilliams @blasten @fluttergithubbot