Removed SwitchListTile accentColor dependency #76909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
19 tasks
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
Note: there was one Google testing failure, which turned out to have been a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tiles with
selected: true, if the tile'sactiveColoris null, the selected item's text color now defaults toThemeData.toggleableActiveColorinstead ofThemeData.accentColor. This removes the widget's accentColor dependency per #56918.This is technically not a breaking change, because it doesn't break any existing tests. However the dependency had been documented.