Removed BottomNavigationBar accentColor dependency #76810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
added 2 commits
February 25, 2021 13:14
19 tasks
darrenaustin
approved these changes
Feb 25, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
LGTM.
Do we need a migration guide for this, or will it be part of a bigger issue's guide?
Contributor
Author
|
There will be a migration guide for #56918 that will cover this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the BottomNavigationBar item from #56918.
When the BottomNavigationBar's type is BottomNavigationBarType.fixed, it now uses the theme's
ColorScheme.primarycolor as the default selectedItemColor for light themes, andColorScheme.secondaryfor dark themes.This PR was tested locally (internal link): cl/359596877
This is a breaking change. The default selectedItemColor for light themes was the theme's
primaryColorfor light themes andaccentColorfor dark themes.Apps that need to configure the selectedItemColor (or the unselectedItemColor) can do so by either setting those parameters in the BottomNavigationBar constructor or with a BottomNavigationBarTheme.