Repeated background images should be clipped to the container #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
abarth
force-pushed
the
clip_image_repeat
branch
from
25e28ef to
e46f480
Compare
Contributor
|
Lgtm. It's notable that we spend a lot of effort trying to make the middle image not overflow but then if we have a repeating image we just use clip. I don't see a much better solution though. |
Contributor
Author
|
Yeah, I tried just adjust the destination rect, but that squished the images along the boarder. We'd need to adjust the source rect too. At that point, we're just implementing clipping, which skia can do just as well as us. |
abarth
added a commit
that referenced
this pull request
Dec 5, 2015
Repeated background images should be clipped to the container
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766