Disable warnings for the dart plugin registrant #76561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
reviewed
Feb 22, 2021
| mainUri, | ||
| newMainDart, | ||
| mainFile, | ||
| // TODO(egarciad): Turn this on when the plugins are fixed. |
Member
There was a problem hiding this comment.
What about plugins that we don't own and can't fix? Should this ever be shown when building an app? Is there something actionable the plugin consumer can do? If so, we should specialize the warning for them.
Author
There was a problem hiding this comment.
For those, we could send PRs to fix their pubspec.yaml. Maybe, we could detect if the app being built is the plugin's example app.
Also, this is an action item to the consumer of the plugin as well, since according to the design, a user can specify the default implementation of a plugin for a platform.
zanderso
added a commit
that referenced
this pull request
Mar 23, 2021
* Revert "Enable dart_plugin_registry_test (#76645)" This reverts commit 109e0bb. * Revert "Apply changes caused by #76662 (#77093)" This reverts commit cdca648. * Revert "Disable clang format in the plugin registrants (#76662)" This reverts commit dadbd47. * Revert "Disable warnings for the dart plugin registrant (#76561)" This reverts commit 098ece5. * Revert "Remove dart_plugin_registry_test timeouts (#76838)" This reverts commit 1610a27. * Revert "Implement dartPluginClass support for plugins (#74469)" This reverts commit b7d4806. Kick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the warnings mentioned in #76396