Skip to content

Remove deprecated TypeMatcher #76331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 26, 2021
Merged

Remove deprecated TypeMatcher #76331

fluttergithubbot merged 2 commits into from
Feb 26, 2021

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 18, 2021

Original PR #73751
Reverted in #75734
Fixes #73910

Internal customers need to be migrated before this can land again.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. c: API break Backwards-incompatible API changes labels Feb 18, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 18, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 18, 2021
@google-cla google-cla bot added the cla: yes label Feb 18, 2021
goderbauer
goderbauer approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for when it's ready to land

This was referenced Feb 19, 2021
Merged
Merged
@Piinks Piinks changed the title [WIP] Remove deprecated TypeMatcher (again) Remove deprecated TypeMatcher Feb 26, 2021
@fluttergithubbot fluttergithubbot merged commit ee54a72 into flutter:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecations at EOL after 1.22 release

3 participants

@Piinks @goderbauer @fluttergithubbot