Migrate to ChannelBuffers.push #76288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
Hixie
force-pushed
the
dispatch2
branch
2 times, most recently
from
ec1da40 to
ed6a59d
Compare
Contributor
Author
|
Blocked on |
Contributor
Author
|
Blocked on flutter/website#5322 |
Contributor
Author
|
|
Hixie
force-pushed
the
dispatch2
branch
2 times, most recently
from
c54e705 to
a256d91
Compare
11 tasks
Contributor
Author
|
|
Hixie
force-pushed
the
dispatch2
branch
2 times, most recently
from
8a7780f to
f109515
Compare
Hixie
force-pushed
the
dispatch2
branch
7 times, most recently
from
b52ca0f to
3ffbfd8
Compare
Contributor
Author
|
cc @goderbauer the tests finally pass, would love your review! |
flutter-dashboard
bot
added
a: accessibility
Hixie
force-pushed
the
dispatch2
branch
2 times, most recently
from
f6136ac to
5762df7
Compare
Contributor
Author
|
I merged this to top of tree. Waiting for #79061 to roll into google3 so that I can test this there more thoroughly. |
Contributor
Author
|
Remerged to top of tree, waiting for #80003 to land in google3 for further testing. |
Contributor
Author
|
I'm landing this now since everything is green, but I fully expect this to get reverted... |
Contributor
Author
|
Interestingly some systems at Google reckon that this reduced codesize by 1-2%, which is an unexpected but nice side effect. |
angjieli
added a commit
that referenced
this pull request
Apr 26, 2021
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 14, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 21, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.