Skip to content

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Dec 5, 2015

Fixes #158

@abarth
Copy link
Contributor Author

abarth commented Dec 5, 2015

@Hixie

@Hixie
Copy link
Contributor

Hixie commented Dec 5, 2015

LGTM.
I love the approach, it's very self-contained and readable.

@abarth
Copy link
Contributor Author

abarth commented Dec 5, 2015

I love the approach, it's very self-contained and readable.

\o/

abarth added a commit that referenced this pull request Dec 5, 2015
@abarth abarth merged commit 503218c into flutter:master Dec 5, 2015
@abarth abarth deleted the image_repeat branch December 5, 2015 09:12
@Hixie
Copy link
Contributor

Hixie commented Dec 5, 2015

does this clip to the output rect? seems like it might overflow if the slices don't exactly line up with the destination.

@abarth
Copy link
Contributor Author

abarth commented Dec 5, 2015

That's a good point. I was testing with a full-screen widget, so I didn't notice. Please file a bug against me. Will fix.

@Hixie
Copy link
Contributor

Hixie commented Dec 5, 2015

#766

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement (or remove) all the ImageRepeat logic.

2 participants