Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 24, 2017

No description provided.

@Hixie
Copy link
Contributor Author

Hixie commented Jan 24, 2017

Obviously this will require an e-mail and so forth.

@Hixie
Copy link
Contributor Author

Hixie commented Jan 24, 2017

Fixes #2343

@abarth
Copy link
Contributor

abarth commented Jan 24, 2017

It might be valuable to have a period of time where the tool accepts both kinds. For example, it could look at pubspec.yaml first and look for flutter.yaml if it doesn't find the flutter key. (If it does find the flutter key, it should verify that flutter.yaml doesn't exist.

Also, consider a message in the case where it falls back to flutter.yaml explaining how to transition to the new location.

@Hixie
Copy link
Contributor Author

Hixie commented Jan 24, 2017

Transitioning is really simple. How about just detecting the flutter.yaml file and saying what to do if it exists? (Rather than actually parsing both, which would require multiple schemas, etc.)

@abarth
Copy link
Contributor

abarth commented Jan 24, 2017

ok

@Hixie
Copy link
Contributor Author

Hixie commented Jan 24, 2017

I have added a check for flutter.yaml files that gets triggered for the same commands that previously checked for a pubspec.yaml file, along with a multiparagraph precise step-by-step explanation for what to do and a pointer to an example. PTAL. :-)

@abarth
Copy link
Contributor

abarth commented Jan 24, 2017

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Jan 24, 2017

I'll merge this while I'm at the office so that I can provide better support to anyone it breaks.

I'll post the following e-mail when I do so:

flutter.yaml merging into pubspec.yaml

The next time you update your Flutter repository, you will find that you need to make a change: you will need to merge your flutter.yaml file into your pubspec.yaml file and then delete your flutter.yaml file.

Just running "flutter run" will give you detailed instructions on how to do this, or you can contact me and I'll help you out.

This is part of an attempt to simplify the Flutter development experience by having fewer files to deal with.

@mit-mit
Copy link
Member

mit-mit commented Jan 24, 2017

Woot, happy to see this being fixed!

@mit-mit
Copy link
Member

mit-mit commented Jan 24, 2017

@devoncarew @pq do we use the presence of a flutter.yaml file for anything in IJ?

@pq
Copy link
Contributor

pq commented Jan 24, 2017

@mit-mit: 👍 => flutter/flutter-intellij#656

@Hixie Hixie merged commit 1bdf351 into flutter:master Jan 24, 2017
@Hixie Hixie deleted the pubspec branch January 24, 2017 19:19
Comment on lines +27 to +28
# - images/a_dot_burr.jpeg
# - images/a_dot_ham.jpeg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To whomever did this, I see you 👀
hamilton the musical scene

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants