Skip to content

Audit and update deprecation warnings #75813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Feb 11, 2021
Merged

Audit and update deprecation warnings #75813

fluttergithubbot merged 2 commits into from
Feb 11, 2021

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 10, 2021

While working on deprecations and dart fixes recently, I found that not all uses of deprecated API were receiving warnings. This is because the annotation must be applied to every use - constructors, parameters and field members.

I did a quick audit and found that some deprecated API is not fully warned, added where needed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. labels Feb 10, 2021
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. labels Feb 10, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 10, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Feb 10, 2021

I am wondering if we should 'reset the clock' on these since they are not fully notified right now.

@Hixie
Copy link
Contributor

Hixie commented Feb 10, 2021

I would support resetting the clock.

Also, LGTM.

goderbauer
goderbauer approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented Feb 10, 2021

I think we should "reset the clock" to give devs more time on these.

HansMuller
HansMuller approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darrenaustin
darrenaustin approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@fluttergithubbot fluttergithubbot merged commit 45c1370 into flutter:master Feb 11, 2021
This was referenced Feb 12, 2021
Merged
Merged
This was referenced Feb 16, 2022
Merged
Merged
@pq pq mentioned this pull request Sep 20, 2023
Open
2 tasks
@Piinks Piinks mentioned this pull request Dec 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

+2 more reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Piinks @Hixie @goderbauer @darrenaustin @HansMuller @fluttergithubbot