Skip to content

Compress module_test_ios xcresult #75736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Feb 10, 2021
Merged

Compress module_test_ios xcresult #75736

jmagman merged 1 commit into from
Feb 10, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 9, 2021 •
edited
Loading

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Feb 9, 2021
@jmagman jmagman self-assigned this Feb 9, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 9, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@jmagman jmagman requested a review from jonahwilliams February 9, 2021 23:58
jonahwilliams
jonahwilliams approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 4329bea into flutter:master Feb 10, 2021
@jmagman jmagman deleted the zip-xcresult branch February 10, 2021 00:10
@jmagman jmagman mentioned this pull request Apr 7, 2021
Merged
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
@jmagman jmagman mentioned this pull request Feb 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compress module_test_ios xcresult in LUCI logs

2 participants

@jmagman @jonahwilliams