Skip to content

added optional configuration parameters for the tab page selector #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gavindoughtie wants to merge 2 commits into from
Closed

added optional configuration parameters for the tab page selector #7553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a7275
added tab config
gavindoughtie Jan 19, 2017
84940ef
fixed rename error
gavindoughtie Jan 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions packages/flutter/lib/src/material/tabs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,14 +822,25 @@ class _TabBarViewState extends State<TabBarView> {
/// ancestor.
class TabPageSelector extends StatelessWidget {
/// Creates a compact widget that indicates which tab has been selected.
TabPageSelector({ Key key, this.controller }) : super(key: key);
TabPageSelector({
Key key,
this.controller,
this.emptyIndicatorFillColor: Colors.transparent,
this.indicatorSize: 12.0
}) : super(key: key);

/// This widget's selection and animation state.
///
/// If [TabController] is not provided, then the value of [DefaultTabController.of]
/// will be used.
final TabController controller;

/// The fill color for an unselected indicator. Defaults to Colors.transparent.
Copy link
Contributor

@Hixie Hixie Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Colors.transparent]

Copy link
Contributor

@Hixie Hixie Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add more color to these docs in a second paragraph, saying why you would set it.

final Color emptyIndicatorFillColor;

/// The size of the indicator. Defaults to 12.0.
final double indicatorSize;

Widget _buildTabIndicator(
int tabIndex,
TabController tabController,
Expand All @@ -848,13 +859,14 @@ class TabPageSelector extends StatelessWidget {
} else {
background = tabController.index == tabIndex ? selectedColor.end : selectedColor.begin;
}
Color borderColor = emptyIndicatorFillColor == Colors.transparent ? selectedColor.end : background;
return new Container(
width: 12.0,
height: 12.0,
width: indicatorSize,
height: indicatorSize,
margin: const EdgeInsets.all(4.0),
decoration: new BoxDecoration(
backgroundColor: background,
border: new Border.all(color: selectedColor.end),
border: new Border.all(color: borderColor),
shape: BoxShape.circle
)
);
Expand All @@ -863,8 +875,8 @@ class TabPageSelector extends StatelessWidget {
@override
Widget build(BuildContext context) {
final Color color = Theme.of(context).accentColor;
final ColorTween selectedColor = new ColorTween(begin: Colors.transparent, end: color);
final ColorTween previousColor = new ColorTween(begin: color, end: Colors.transparent);
final ColorTween selectedColor = new ColorTween(begin: emptyIndicatorFillColor, end: color);
final ColorTween previousColor = new ColorTween(begin: color, end: emptyIndicatorFillColor);
final TabController tabController = controller ?? DefaultTabController.of(context);
final Animation<double> animation = new CurvedAnimation(
parent: tabController.animation,
Expand Down