Skip to content

[flutter_releases] Flutter 1.26.0-17.2.pre Beta Framework Cherrypicks #75303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 11 commits into from
Feb 3, 2021
Merged

[flutter_releases] Flutter 1.26.0-17.2.pre Beta Framework Cherrypicks #75303

christopherfujino merged 11 commits into from
Feb 3, 2021

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Feb 3, 2021 •
edited
Loading

Scheduled Cherrypicks

Infra-Specific Cherrypicks

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 3, 2021
@google-cla
Copy link

google-cla bot commented Feb 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 3, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 February 3, 2021 01:37
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 3, 2021

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.26-candidate.17. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.26-candidate.17 to master February 3, 2021 01:37
@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 February 3, 2021 01:38
@bkonyi @christopherfujino
Suppress 'Info: Compiling without sound null safety' message when bui…
858c84d 
…lding flutter_tools (flutter#74740)

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes flutter#74366
@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 3, 2021
@christopherfujino christopherfujino marked this pull request as draft February 3, 2021 02:10
@christopherfujino christopherfujino marked this pull request as ready for review February 3, 2021 22:17
@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Feb 3, 2021
pcsosinski
pcsosinski approved these changes Feb 3, 2021
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@christopherfujino christopherfujino merged commit 79b49b9 into flutter:flutter-1.26-candidate.17 Feb 3, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-canddiate.17 branch February 3, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pcsosinski pcsosinski pcsosinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@christopherfujino @pcsosinski @kenzieschmoll @Piinks @goderbauer @bkonyi @jmagman