Adopt subshard naming convention in build_tests #75179
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Fallback to old naming convention is working: https://ci.chromium.org/p/flutter/builders/try/Linux%20build_tests/10200 |
…#75303) * Only show devtools deep links for render overflow errors (#74916) * Add fixes for nullOk changes (#74866) * [flutter_tools] delete old directories when unzipping ontop of them (#74818) Fixes #74772 stale files from previous SDKs were getting left in the cache, confusing the analyzer. * Make flutter create --smaple null-safe (#74844) * Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740) The CFE now logs to stdout by default when compiling a program which has non-null-safe dependencies. Since flutter_tools has not yet migrated, we need to suppress this message when compiling the tool. Fixes #74366 * Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033) * Adopt tool_test shard builders (#75171) * Adopt subshard naming convention in build_tests (#75179) * Mark tool_integration_tests not flaky (#75273) * roll flutter/plugins to ToT to fix analysis error * update engine hash Co-authored-by: Kenzie Schmoll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Ben Konyi <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
2 participants
Adopt new subshard naming convention introduced in #75033 in
build_tests. The total number of subshards is encoded in the subshard name itself (2_8means "2 of 8") so now there doesn't have to be coordination between constants in the framework and infra, likekBuildTestShardCount.The fallback will be removed once the infra
build_testsbuilders adopt the new name in https://github.com/flutter/infra/pull/341.