Skip to content

Avoid iOS local networking dialog in integration tests #75163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Feb 1, 2021
Merged

Avoid iOS local networking dialog in integration tests #75163

jmagman merged 1 commit into from
Feb 1, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 1, 2021

Use the flutter run --no-publish-port flag introduced in #67452 to avoid the local network popup in integration tests.

Fixes #75048

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically labels Feb 1, 2021
@jmagman jmagman self-assigned this Feb 1, 2021
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
jonahwilliams
jonahwilliams approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 91aad2b into flutter:master Feb 1, 2021
@jmagman jmagman deleted the no-publish-port branch February 1, 2021 21:33
@jmagman jmagman mentioned this pull request Feb 1, 2021
Closed
This was referenced Feb 9, 2021
Closed
Closed
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Mar 17, 2021
@jmagman @christopherfujino
Avoid iOS local networking dialog in integration tests (flutter#75163)
1764e4c
christopherfujino added a commit that referenced this pull request Mar 19, 2021
@christopherfujino @jmagman
@godofredoc @pq
[flutter_releases] Flutter Stable 2.0.3 Framework Cherrypicks (#78489)
4d7946a 
* Avoid iOS local networking dialog in integration tests (#75163)

* ios_platform_view tests pass when device rotated (#75665)

* Consolidate ascii spinner stop in devtools activation (#75679)

* Fix problem causing tasks to timeout. (#76028)

This is because the command was actually collecting logs continuously
from the device. Additionally idevicesyslog does not have a reboot
option.

Bug: #76027

* fix Autovalidate enum references in fix data (#77419)

* roll engine cherrypicks

Co-authored-by: Jenn Magder <[email protected]>
Co-authored-by: godofredoc <[email protected]>
Co-authored-by: Phil Quitslund <[email protected]>
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

complex_layout_ios__start_up brings up a system dialog that makes next tests fail.

2 participants

@jmagman @jonahwilliams