Split tools_tests subshards into separate shards to support sub-sub-sharding #75033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
force-pushed
the
shard-integration
branch
from
b4158e6 to
afa707f
Compare
jmagman
force-pushed
the
shard-integration
branch
5 times, most recently
from
b4a8fd9 to
7846096
Compare
jmagman
force-pushed
the
shard-integration
branch
from
7846096 to
a336773
Compare
jmagman
force-pushed
the
shard-integration
branch
from
a336773 to
5af1d57
Compare
Member
Author
godofredoc
approved these changes
Jan 30, 2021
christopherfujino
approved these changes
Feb 1, 2021
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making this change!
This was referenced Feb 1, 2021
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Feb 3, 2021
8 tasks
christopherfujino
added a commit
that referenced
this pull request
Feb 3, 2021
…#75303) * Only show devtools deep links for render overflow errors (#74916) * Add fixes for nullOk changes (#74866) * [flutter_tools] delete old directories when unzipping ontop of them (#74818) Fixes #74772 stale files from previous SDKs were getting left in the cache, confusing the analyzer. * Make flutter create --smaple null-safe (#74844) * Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740) The CFE now logs to stdout by default when compiling a program which has non-null-safe dependencies. Since flutter_tools has not yet migrated, we need to suppress this message when compiling the tool. Fixes #74366 * Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033) * Adopt tool_test shard builders (#75171) * Adopt subshard naming convention in build_tests (#75179) * Mark tool_integration_tests not flaky (#75273) * roll flutter/plugins to ToT to fix analysis error * update engine hash Co-authored-by: Kenzie Schmoll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Ben Konyi <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tool_general_tests,tool_command_tests, andtool_integration_teststop-level shards.web_long_running_testsandbuild_tests. Instead of0,1,2_lastwith the total count (3) stored in a framework repo constant, which requires an infra commit and framework repo commit to change, instead support1_3,2_3,3_3subshard names where the total number is encoded in the name. This allows shard numbers to be changed in the config without a corresponding framework commit.Use one-indexing for sanity so it's not (0 of 2, 1 of 2).
tool_integration_tests.smoke_testshard and support subsharding there. Add integration tests using this shard to test the subsharding logic.Infra side at https://github.com/flutter/infra/pull/339
Framework part of #75003