Skip to content

Show an X when images can't load. #74972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 3, 2021
Merged

Show an X when images can't load. #74972

fluttergithubbot merged 1 commit into from
Feb 3, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 29, 2021

When an image can't be shown, in debug mode, this shows a red X with an error message. Should make it a bit easier to debug missing images.

Fixes #125.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 29, 2021
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@Hixie Hixie mentioned this pull request Jan 29, 2021
Closed
@skia-gold
Copy link

skia-gold commented Jan 29, 2021

Gold has detected about 3 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/74972

@skia-gold
Copy link

skia-gold commented Jan 29, 2021

Gold has detected about 2 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/74972

@Hixie Hixie mentioned this pull request Jan 30, 2021
Open
@Hixie Hixie marked this pull request as ready for review February 1, 2021 20:32
@Hixie
Copy link
Contributor Author

Hixie commented Feb 2, 2021

cc @goderbauer

goderbauer
goderbauer approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/foundation/constants.dart Outdated
Copy link
Member

@goderbauer goderbauer Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn this into a {@tool snippet} so it gets analyzed?

Copy link
Contributor Author

@Hixie Hixie Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

@Hixie Hixie Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to revert this, the snippet analysis logic doesn't like bare asserts.

@Hixie
Copy link
Contributor Author

Hixie commented Feb 3, 2021

Thanks for the review, will land on green.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 3, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie Hixie force-pushed the image_error branch 2 times, most recently from 2261bd8 to 2c6cdff Compare February 3, 2021 18:45
@fluttergithubbot fluttergithubbot merged commit 6665922 into flutter:master Feb 3, 2021
@Hixie Hixie mentioned this pull request Feb 15, 2021
Closed
@gaaclarke gaaclarke mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using a resource not listed in flutter.yaml should show a red X

4 participants

@Hixie @skia-gold @fluttergithubbot @goderbauer