Skip to content

NNBD integration_test #74922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Jan 29, 2021
Merged

NNBD integration_test #74922

fluttergithubbot merged 5 commits into from
Jan 29, 2021

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 28, 2021

Fixes #71379

Unlike flutter/plugins#3158, I did this migration with the tool and avoided much refactoring.

I think we should still refactor the way the vm service ivar is handled, but that can be done in a separate patch.

This will require a g3fix to enable null-safety on the build internally.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 28, 2021
@google-cla google-cla bot added the cla: yes label Jan 28, 2021
@dnfield dnfield requested a review from ditman January 28, 2021 19:20
jonahwilliams
jonahwilliams approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ditman
ditman approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much looking forward to this! Flutter analyze has a few opinions, though (see analyze-linux check?)

@dnfield
Copy link
Contributor Author

dnfield commented Jan 28, 2021

I forgot to migrate the example. Also looking into analysis issues.

@dnfield
Copy link
Contributor Author

dnfield commented Jan 28, 2021

One thing I'm not 100% sure of - the driver migration made requestData have a non-null string parameter.

This package was calling wtih null in a couple places. I've replaced those with the empty string for now.

goderbauer
goderbauer approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/integration_test/lib/integration_test.dart
@visibleForTesting vm.VmService? vmService,
}) async {
assert(streams != null);
assert(streams != null); // ignore: unnecessary_null_comparison
Copy link
Member

@goderbauer goderbauer Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the other packages we just disabled this lint in the analyzer_options.yaml

@dnfield
Copy link
Contributor Author

dnfield commented Jan 28, 2021

Test failures are real, looking into it.

@dnfield
Copy link
Contributor Author

dnfield commented Jan 28, 2021

Issue was that requestData needds to accept null in driver. Updated that as part of this PR.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 29, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 29, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield mentioned this pull request Jan 29, 2021
Closed
@fluttergithubbot fluttergithubbot merged commit cca9592 into flutter:master Jan 29, 2021
Hixie added a commit that referenced this pull request Jan 29, 2021
@Hixie
Revert "NNBD integration_test (#74922)"
56e065f 
This reverts commit cca9592.
@Hixie Hixie mentioned this pull request Jan 29, 2021
Merged
darrenaustin pushed a commit that referenced this pull request Jan 29, 2021
@Hixie
Revert "NNBD integration_test (#74922)" (#75030)
87b0436 
This reverts commit cca9592.
dnfield added a commit to dnfield/flutter that referenced this pull request Jan 30, 2021
@dnfield
Revert "Revert "NNBD integration_test (flutter#74922)" (flutter#75030)"
53af56b 
This reverts commit 87b0436.
@dnfield dnfield mentioned this pull request Jan 30, 2021
Merged
8 tasks
dnfield added a commit that referenced this pull request Feb 1, 2021
@dnfield
Reland integration_test NNBD (#75074)
d309254 
* Revert "Revert "NNBD integration_test (#74922)" (#75030)"

This reverts commit 87b0436.

* fix bad merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@ditman ditman ditman approved these changes

@jiahaog jiahaog Awaiting requested review from jiahaog

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[integration_test] Needs null safety migration

5 participants

@dnfield @fluttergithubbot @goderbauer @ditman @jonahwilliams