Skip to content

InputDecorator negative baseline error message #74837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jan 29, 2021
Merged

InputDecorator negative baseline error message #74837

fluttergithubbot merged 2 commits into from
Jan 29, 2021

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jan 27, 2021 •
edited
Loading

Report the child that has a negative baseline.

Fixes #74326

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 27, 2021
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
justinmc
justinmc approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

So #74326 will not really be fixed, but it will get a much nicer error message and a test confirming that the behavior is intended. I'm on board with that. The author of that issue should update their code to not produce a negative baseline.

@fluttergithubbot fluttergithubbot merged commit fb9ff62 into flutter:master Jan 29, 2021
@LongCatIsLooong LongCatIsLooong deleted the input-decorator-negative-baseline branch January 29, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InputDecorator assertions failed: baseline != null && baseline >= 0.0

3 participants

@LongCatIsLooong @justinmc @fluttergithubbot