Skip to content

[flutter_tools] opt all flutter tool libraries and tests out of null safety. #74832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 7 commits into from
Jan 27, 2021
Merged

[flutter_tools] opt all flutter tool libraries and tests out of null safety. #74832

zanderso merged 7 commits into from
Jan 27, 2021

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jan 27, 2021

Opt the flutter tool out of null safety.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 27, 2021
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
jmagman
jmagman approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter_tools/test/general.shard/flutter_project_metadata_test.dart
}
Copy link
Member

@jmagman jmagman Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh.

This was referenced Jan 27, 2021
Closed
Merged
christopherfujino
christopherfujino suggested changes Jan 27, 2021
View reviewed changes
packages/flutter_tools/bin/tool_backend.dart Outdated

// @dart = 2.8

// @dart = 2.9
Copy link
Contributor

@christopherfujino christopherfujino Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zanderso zanderso merged commit 74bd7b6 into flutter:master Jan 27, 2021
@jmagman jmagman mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @jmagman @zanderso @christopherfujino