[flutter_tools] delete old directories when unzipping ontop of them #74818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jonahwilliams
requested review from
zanderso
and removed request for
zanderso
Contributor
Author
|
oof, that doesn't work |
Contributor
Author
|
Right, because we have some shared directories.... |
Contributor
Author
|
now I think it is working... |
zanderso
reviewed
Jan 27, 2021
| _ensureExists(location); | ||
|
|
||
| try { | ||
| print(tempFile.path); |
zanderso
reviewed
Jan 27, 2021
| tempFile.fileSystem.path.basenameWithoutExtension(tempFile.path) | ||
| ); | ||
| if (destination.existsSync()) { | ||
| destination.deleteSync(recursive: true); |
Member
There was a problem hiding this comment.
What should/will happen if this throws an exception?
Contributor
Author
There was a problem hiding this comment.
hmm, I'm not really sure. I don't know if - say there was a missing permission, would the unzip fail anyway? I can rethrow a tool exit to start?
Contributor
Author
There was a problem hiding this comment.
actually, the ones we care about should go to error handling io, for the others we can let it crash.
Member
There was a problem hiding this comment.
It looks like deleteSync is already covered by the ErrorHandlingFileSystem. Additionally it looks like this:
covers some additional cases that might be useful here?
zanderso
approved these changes
Jan 27, 2021
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Feb 3, 2021
…lutter#74818) Fixes flutter#74772 stale files from previous SDKs were getting left in the cache, confusing the analyzer.
christopherfujino
added a commit
that referenced
this pull request
Feb 3, 2021
…#75303) * Only show devtools deep links for render overflow errors (#74916) * Add fixes for nullOk changes (#74866) * [flutter_tools] delete old directories when unzipping ontop of them (#74818) Fixes #74772 stale files from previous SDKs were getting left in the cache, confusing the analyzer. * Make flutter create --smaple null-safe (#74844) * Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740) The CFE now logs to stdout by default when compiling a program which has non-null-safe dependencies. Since flutter_tools has not yet migrated, we need to suppress this message when compiling the tool. Fixes #74366 * Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033) * Adopt tool_test shard builders (#75171) * Adopt subshard naming convention in build_tests (#75179) * Mark tool_integration_tests not flaky (#75273) * roll flutter/plugins to ToT to fix analysis error * update engine hash Co-authored-by: Kenzie Schmoll <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Ben Konyi <[email protected]> Co-authored-by: Jenn Magder <[email protected]>
This was referenced Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74772
stale files from previous SDKs were getting left in the cache, confusing the analyzer.