Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@fdddf87...05b4bec

2021-01-22 [email protected] Started using Dart_CreateInGroup when using spawn on a release build (flutter/engine#23782)
2021-01-22 [email protected] [web] Fix shadows for arbitrary paths on PhysicalShape (flutter/engine#23830)
2021-01-22 [email protected] Roll Skia from bfc9be0f773f to 3193ff271628 (5 revisions) (flutter/engine#23872)
2021-01-22 [email protected] Remove workarounds now that type promotion accounts for local boolean variables. (flutter/engine#23862)
2021-01-22 [email protected] Roll Skia from 6a272434c2b2 to bfc9be0f773f (2 revisions) (flutter/engine#23867)
2021-01-22 [email protected] Share Android surface GrDirectContext (flutter/engine#23798)
2021-01-22 [email protected] reland of flutter/engine#23634 (flutter/engine#23865)
2021-01-22 [email protected] Roll Skia from cc6961b9ac5e to 6a272434c2b2 (3 revisions) (flutter/engine#23864)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 55 untriaged digest(s) on patchset 8.
View them at https://flutter-gold.skia.org/cl/github/74540

@zanderso
Copy link
Member

@ferhatb please take a look at the diffs.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #74540 at sha c3d2eaf

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 23, 2021
@zanderso
Copy link
Member

/cc @yjbanov

@zanderso zanderso merged commit 97878a2 into flutter:master Jan 25, 2021
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-a87ae715-e60b-48ac-a603-68075ef4df7e-1611361386 branch January 30, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants