Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 21, 2021

The test framework previously made it impossible to actually catch all exceptions from the message channels system, because it "forked" the future chain and didn't catch exceptions on its end of the fork. This catches the exceptions on the forked branch. Originally I tried flattening the chain but that causes Zone issues in some tests with FakeAsync.

This unblocks flutter/packages#265 which, somehow, I don't even remember how, is part of the yak shave to fixing #64830.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2021
@google-cla google-cla bot added the cla: yes label Jan 21, 2021
The test framework previously made it impossible to actually catch all exceptions from the message channels system, because it "forked" the future chain and didn't catch exceptions on its end of the fork. This flattens the future chain.
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 37a0189 into flutter:master Jan 27, 2021
@Hixie Hixie deleted the futures-in-test branch January 28, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants