Skip to content

Block the tree on mac_android test failures running on luci. - #74441

Merged
godofredoc merged 3 commits into
flutter:masterfrom
godofredoc:add_mac_android
Jan 21, 2021
Merged

godofredoc merged 3 commits into
flutter:masterfrom
godofredoc:add_mac_android

Conversation

@godofredoc

Copy link
Copy Markdown
Contributor

Start blocking the tree on LUCI mac android failures. Mac android tests will now run exclusively on LUCI.

Bug: #74431

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 21, 2021
@google-cla google-cla Bot added the cla: yes label Jan 21, 2021

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dev/prod_builders.json Outdated
"name": "Mac_android android_semantics_integration_test",
"repo": "flutter",
"task_name": "mac_android_android_semantics_integration_test",
"flaky": true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can you mark this not flaky? this should pass at ToT

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread dev/prod_builders.json Outdated
"name": "Mac_android hot_mode_dev_cycle__benchmark",
"repo": "flutter",
"task_name": "mac_android_hot_mode_dev_cycle__benchmark",
"flaky": true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also not be flaky, as it should pass after a recent fix

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

75dc45a should have fixed this one.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread dev/prod_builders.json Outdated
"name": "Mac_android microbenchmarks",
"repo": "flutter",
"task_name": "mac_android_microbenchmarks",
"flaky": true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you mark this as not flaky? I believe this is a recent regression.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc
godofredoc merged commit 3c27a56 into flutter:master Jan 21, 2021
@godofredoc
godofredoc deleted the add_mac_android branch January 21, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants