Skip to content

Revert "Manually close tree while devicelab staging is failing (#74434)" - #74438

Merged
christopherfujino merged 1 commit into
flutter:masterfrom
chris-forks:green-tree
Jan 22, 2021
Merged

christopherfujino merged 1 commit into
flutter:masterfrom
chris-forks:green-tree

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Jan 21, 2021 •

Copy link
Copy Markdown
Contributor

This reverts commit 444c954.

Should NOT be landed until the framework prod_builders.json file has been updated with the mac/android devicelab tasks.

part of (but does not alone fix) #74431

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 21, 2021
@google-cla google-cla Bot added the cla: yes label Jan 21, 2021
@christopherfujino
christopherfujino marked this pull request as ready for review January 22, 2021 00:12
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino

Copy link
Copy Markdown
Contributor Author

landing on red flutter-build to fix tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants