Skip to content

Manually close tree while devicelab staging is failing - #74434

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:close-tree
Jan 21, 2021
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:close-tree

Conversation

@jmagman

@jmagman jmagman commented Jan 21, 2021

Copy link
Copy Markdown
Member

Devicelab tests are failing in staging but not running in cocoon, thus not blocking tree. Manually red the tree until the test is fixed #74431

Post-submit test failure to not fail PR tests #74433.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 21, 2021
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Jan 21, 2021

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
jmagman merged commit 444c954 into flutter:master Jan 21, 2021
christopherfujino added a commit to chris-forks/flutter that referenced this pull request Jan 21, 2021
@jmagman
jmagman deleted the close-tree branch January 21, 2021 21:00
christopherfujino added a commit that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests running in devicelab_staging, not blocking tree

2 participants