Repository navigation
manually close tree while devicelab staging is failing - #74433
Closed
christopherfujino wants to merge 1 commit into
Closed
christopherfujino wants to merge 1 commit into
christopherfujino wants to merge 1 commit into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
Bot
added
the
c: contributor-productivity
jmagman
reviewed
Jan 21, 2021
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
Can we fail on a post-submit test that won't prevent pre-submit PR tests from running? I think some of them won't run when analyze fails.
Contributor
Author
|
Closed in favor of #74434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devicelab tests are failing in staging but not running in cocoon, thus not blocking tree. Manually red the tree until the test is fixed.