TextFormField does not get blurred when tapped outside of the widget. #74354

stevenmetzger · 2021-01-20T21:26:15Z

This PR adds support the optional argument (forceSubmitOnFocusLost) to TextField. This is needed to complete work on flutter/engine#22517. This PR was requested during review flutter/engine#22517 (review).

This fixes the following regression:
Fixes #64245

This fix was proposed in the comments of this issue here:
#64245 (comment)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

* Add optional argument (forceCloseConnectionOnBlur) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

flutter-dashboard · 2021-01-20T21:26:25Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2021-02-11T00:40:26Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

LongCatIsLooong · 2021-02-11T02:23:24Z

oops sorry I'll take a look tonight.

LongCatIsLooong · 2021-02-11T04:50:49Z

packages/flutter/lib/src/material/text_field.dart

    this.autofocus = false,
    this.obscuringCharacter = '•',
    this.obscureText = false,
+    this.forceCloseConnectionOnBlur = false,


We probably shouldn't mention "connection" in the text field api. Even to EditableText if feels the "connection" should be an implementation detail.

I agree, connection should be an implementation detail. I changed this to forceSubmitOnFocusLost, because the onSubmitted callback will be invoked when the user clicks out of the text field.

LongCatIsLooong · 2021-02-11T04:52:54Z

packages/flutter/lib/src/services/text_input.dart

  /// Defaults to false.
  final bool obscureText;

+  /// Previously, Flutter for Web behaved like a web page. If user clicked on an


Most developers won't be too interested in the story behind the parameter. These should probably be code comments.

I removed the story and included a brief description of the behavior.

LongCatIsLooong · 2021-02-11T04:56:57Z

packages/flutter/lib/src/services/text_input.dart

+  /// https://github.com/flutter/flutter/issues/64245
+  ///
+  /// This flag provides a workaround to the regression allowing developers to
+  /// optionally force the connection to close on blur, as suggested in the comments


Could you explain in the documentation what "blur" means?

I changed "blur" to "focus lost". Blur is the opposite of focus, but saying "focus lost" is probably easier to understand.

* Add optional argument (forceSubmitOnFocusLost) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

flutter-dashboard · 2021-02-19T19:28:44Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Fabrice-TEICHTEIL-KOENIGSBUCH · 2021-05-14T00:25:39Z

@LongCatIsLooong is there anything still to be done following last review cycle?

Piinks · 2021-06-10T17:27:21Z

(triage) Hi @stevenmetzger would you like to continue with this change?

stevenmetzger · 2021-06-10T18:07:04Z

Hi @Piinks, yes I would like to continue with this change. But it's been here for so long that the corresponding change to flutter/engine is out of date. If I were to rebase both of these changes would they go through? What is the next step to continue here? Sorry for being unfamiliar with the process, this is my first commit to this project.

jonahwilliams · 2021-06-10T18:08:59Z

From my reading of flutter/engine#22517 , it sounds like this might be fixed via #82575

Piinks · 2021-06-10T18:21:18Z

Thanks @jonahwilliams! @stevenmetzger can you confirm that the issue you were trying to resolve is fixed? If so, we can close these changes.

Fabrice-TEICHTEIL-KOENIGSBUCH · 2021-06-11T00:38:52Z

Hi @Piinks @jonahwilliams we opened the issue that this PR fixes: https://github.com/flutter/flutter/issues/64245#issuecomment-681815149.
I don't think that https://github.com/flutter/flutter/pull/82575 will provide a complete solution to our problem.
We need a behavior similar to Google Sheets: when a user clicks or taps outside of a text field, the value should be submitted to the backend immediately, both for web and mobile.
I believe the current PR addresses both platforms, as well as taps in addition to mouse clicks.
And it is pretty efficient and simple to use with just a parameter to set :)
We would love to see it eventually landed, but it is stuck in review for months.

jonahwilliams · 2021-06-11T01:17:13Z

In that case I don't believe you need an engine change, just an update to the text field to submit when focus is lost.

Piinks · 2021-08-17T21:58:58Z

This PR has not been updated in a while, and it currently is failing several tests. I am going to close it for now, but if you would like to return to this change, please feel free to re-open it. Thank you for the contribution!

TextFormField does not get blurred when tapped outside of the widget.

0a4516e

* Add optional argument (forceCloseConnectionOnBlur) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 20, 2021

google-cla bot added the cla: yes label Jan 20, 2021

stevenmetzger mentioned this pull request Jan 20, 2021

TextFormField does not get blurred when tapped outside of the widget. flutter/engine#22517

Closed

10 tasks

HansMuller requested a review from LongCatIsLooong January 22, 2021 00:38

LongCatIsLooong reviewed Feb 11, 2021

View reviewed changes

stevenmetzger added 2 commits February 19, 2021 14:04

TextFormField does not get blurred when tapped outside of the widget.

54c3091

* Add optional argument (forceSubmitOnFocusLost) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

Merge branch 'master' of https://github.com/stevenmetzger/flutter

a1d48f9

HansMuller mentioned this pull request Jun 10, 2021

[flutter] when primary mouse pointers don't contact a focused node, reset the focus #82575

Merged

Piinks added the a: text input Entering text in a text field or keyboard related problems label Aug 17, 2021

Piinks closed this Aug 17, 2021

TextFormField does not get blurred when tapped outside of the widget. #74354

TextFormField does not get blurred when tapped outside of the widget. #74354

Uh oh!

Conversation

stevenmetzger commented Jan 20, 2021 • edited by Piinks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jan 20, 2021

Uh oh!

flutter-dashboard bot commented Feb 11, 2021

Uh oh!

LongCatIsLooong commented Feb 11, 2021

Uh oh!

LongCatIsLooong Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

stevenmetzger Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

stevenmetzger Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

stevenmetzger Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Feb 19, 2021

Uh oh!

Fabrice-TEICHTEIL-KOENIGSBUCH commented May 14, 2021

Uh oh!

Piinks commented Jun 10, 2021

Uh oh!

stevenmetzger commented Jun 10, 2021

Uh oh!

jonahwilliams commented Jun 10, 2021

Uh oh!

Piinks commented Jun 10, 2021

Uh oh!

Fabrice-TEICHTEIL-KOENIGSBUCH commented Jun 11, 2021

Uh oh!

jonahwilliams commented Jun 11, 2021

Uh oh!

Piinks commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stevenmetzger commented Jan 20, 2021 •

edited by Piinks

Loading