Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 15, 2021

Need more logs to track down #73917. Add --verbose flag to flutter build.

@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Jan 15, 2021
@jmagman jmagman self-assigned this Jan 15, 2021
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 15, 2021
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit d603ee1 into flutter:master Jan 15, 2021
@jmagman jmagman deleted the watch-verbose branch January 15, 2021 23:31
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2025
These can be useful, but were probably left in past the point where they
are always useful:

- #58018
- #56342
- #74080

... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.

Will ask the CI gods if any of this was load-bearing before sending out
for review.
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2025
#162853)

<!-- start_original_pr_link -->
Reverts: #162644
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: At least one post-submit test depends on the
output of `--verbose`.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {cbracken, reidbaker, jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
These can be useful, but were probably left in past the point where they
are always useful:

- #58018
- #56342
- #74080

... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.

Will ask the CI gods if any of this was load-bearing before sending out
for review.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants