Skip to content

Remove flaky non-e2e test #73986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jan 15, 2021
Merged

Remove flaky non-e2e test #73986

jmagman merged 1 commit into from
Jan 15, 2021

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jan 14, 2021

Fixes #73873

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 14, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 14, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@liyuqian liyuqian requested a review from jmagman January 14, 2021 22:56
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@liyuqian liyuqian mentioned this pull request Jan 14, 2021
Closed
jmagman
jmagman approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this sounds good to me, once the merge conflict and Could not find an option named "results-file". error is fixed(?).

@christopherfujino
Copy link
Contributor

christopherfujino commented Jan 14, 2021

I suspect rebasing off of upstream will fix the Could not find an option named "results-file". error. This is a new flag that was added to the devicelab runner.

@jmagman
Copy link
Member

jmagman commented Jan 14, 2021

I suspect rebasing off of upstream will fix the Could not find an option named "results-file". error. This is a new flag that was added to the devicelab runner.

He's right, rebase past #72765 your parent is even older.

@liyuqian liyuqian force-pushed the no_multi_without_e2e branch from 69952f2 to 5d712b3 Compare January 14, 2021 23:57
@liyuqian
Copy link
Contributor Author

liyuqian commented Jan 14, 2021

Wow, things changed a lot. Rebased :)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jan 15, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Contributor

christopherfujino commented Jan 15, 2021

Wow, things changed a lot. Rebased :)

Welcome back :)

@jmagman
Copy link
Member

jmagman commented Jan 15, 2021

TAP failure not related, marking as good.

@jmagman
Copy link
Member

jmagman commented Jan 15, 2021

Actually FRoB seems mad and setGitHubCheckToPass isn't working, just merging this fella.

@jmagman jmagman merged commit d676d25 into flutter:master Jan 15, 2021
@jmagman jmagman mentioned this pull request Jan 15, 2021
Closed
@liyuqian liyuqian deleted the no_multi_without_e2e branch January 19, 2021 18:27
@jmagman jmagman mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

multi_widget_construction_perf__timeline_summary timed out

4 participants

@liyuqian @christopherfujino @jmagman @fluttergithubbot